Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix equality typos in Documentation for Ryy, Rxx and Rzx gates (backport #13226) #13229

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Fix equality typos in Documentation for Ryy, Rxx and Rzx gates (backport #13226) #13229

merged 1 commit into from
Sep 27, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 27, 2024

Summary

This PR resolves #13225 by fixing the typos in the documentation for the Ryy, Rxx and Rzx gates.

Details and comments

If I am not mistaken, these are the proper equalities. I also checked the result with numpy:

>>> import qiskit
>>> import numpy as np
>>> Ryy = qiskit.circuit.library.standard_gates.RYYGate(theta=np.pi)
>>> np.isclose(np.array(Ryy), -1j*np.kron(np.array(Y), np.array(Y)))
array([[ True,  True,  True,  True],
       [ True,  True,  True,  True],
       [ True,  True,  True,  True],
       [ True,  True,  True,  True]])
>>> Rxx = qiskit.circuit.library.standard_gates.RXXGate(theta=np.pi)
>>> np.isclose(np.array(Rxx), -1j*np.kron(np.array(X), np.array(X)))
array([[ True,  True,  True,  True],
       [ True,  True,  True,  True],
       [ True,  True,  True,  True],
       [ True,  True,  True,  True]])
>>> Rzx = qiskit.circuit.library.standard_gates.RZXGate(theta=np.pi)
>>> np.isclose(np.array(Rzx), -1j*np.kron(np.array(X), np.array(Z)))
array([[ True,  True,  True,  True],
       [ True,  True,  True,  True],
       [ True,  True,  True,  True],
       [ True,  True,  True,  True]])
```<hr>This is an automatic backport of pull request #13226 done by [Mergify](https://mergify.com).

@jofrevalles @mergify
Fix typos in R gates (#13226)
4b17a3e 
(cherry picked from commit 1686815)
@mergify mergify bot requested a review from a team as a code owner September 27, 2024 11:17
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the following people are relevant to this code:

  • @Cryoris
  • @Qiskit/terra-core
  • @ajavadia

@github-actions github-actions bot added documentation Something is not clear or an error documentation Changelog: None Do not include in changelog Community PR PRs from contributors that are not 'members' of the Qiskit repo labels Sep 27, 2024
@github-actions github-actions bot added this to the 1.2.3 milestone Sep 27, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11069648430

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 20 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.003%) to 89.759%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 94.02%
qiskit/transpiler/passes/synthesis/unitary_synthesis.py 2 88.39%
crates/qasm2/src/lex.rs 5 92.23%
crates/qasm2/src/parse.rs 12 97.15%
Totals Coverage Status
Change from base Build 11037032994: -0.003%
Covered Lines: 66878
Relevant Lines: 74508
💛 - Coveralls

@Cryoris Cryoris added this pull request to the merge queue Sep 27, 2024
Merged via the queue into stable/1.2 with commit 631abab Sep 27, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cryoris Cryoris Cryoris approved these changes

Assignees
No one assigned
Labels
Changelog: None Do not include in changelog Community PR PRs from contributors that are not 'members' of the Qiskit repo documentation Something is not clear or an error documentation
Projects
Contributor Monitoring
Status: Done
Milestone
1.2.3
Development

Successfully merging this pull request may close these issues.
4 participants
@qiskit-bot @coveralls @Cryoris @jofrevalles